Hi, I've regenerated this webrev as well: http://cr.openjdk.java.net/~clanger/webrevs/8232748.11u/ (with JDK-8223678 and JDK-8232572 applied)
Patch content looks identical to the one already reviewed. I'd volunteer to push this in order with the other patches. Cheers Christoph > -----Original Message----- > From: jdk-updates-dev <[email protected]> On > Behalf Of Andrew Hughes > Sent: Donnerstag, 12. März 2020 19:12 > To: Severin Gehwolf <[email protected]>; jdk-updates- > [email protected] > Cc: build-dev <[email protected]> > Subject: Re: [RFR] [11u] JDK-8232748: "Build static versions of certain JDK > libraries" > > > > On 12/03/2020 10:25, Severin Gehwolf wrote: > > Hi Andrew, > > > > On Thu, 2020-02-27 at 15:43 +0100, Severin Gehwolf wrote: > >> On Thu, 2020-02-27 at 04:52 +0000, Andrew Hughes wrote: > >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8232748 > >>> Webrev: > https://cr.openjdk.java.net/~andrew/openjdk11/8232748/webrev.01/ > >>> > >>> This patch adds targets to the build so that static versions of the JDK > >>> native libraries can be built, using static-libs-image. Such static > >>> versions of the libraries are required for consumption by Graal. > >>> > >>> With JDK-8210459 now in 11u, this is a largely clean backport, aside > >>> from some context changes, due to additional targets (JCov, JMH) being > >>> present in trunk: > >>> > >>> * In make/Bundles.gmk, 11u does not have jcov-bundles > >>> * In make/Main.gmk, 11u does not have jcov-image or jcov-bundles > >>> * In make/autoconf/spec.gmk.in, 11u does not have JMH_CORE_JAR, > etc or > >>> JCOV_BUNDLE_NAME. > >>> * In make/conf/jib-profiles.js, the dependencies list in 11u doesn't > >>> include jmh and jcov. > > > > Right, those changes look fine to me. > > > > Reviewed. Please add jdk11u-fix-request label to the bug. > > > >>> Building the new target, static-libs-image, succeeded. This should have > >>> no effect on other targets. > >> > >> Unfortunately this patch doesn't work. While a build of static-libs- > >> image succeeds, it doesn't create the image in build/<config- > >> name>/images. Expected is this: > >> > >> $ find build/linux-x86_64-normal-server-release/images/static-libs/ > >> build/linux-x86_64-normal-server-release/images/static-libs/ > >> build/linux-x86_64-normal-server-release/images/static-libs/lib > >> build/linux-x86_64-normal-server-release/images/static- > libs/lib/libj2pkcs11.a > >> build/linux-x86_64-normal-server-release/images/static- > libs/lib/libj2pcsc.a > >> build/linux-x86_64-normal-server-release/images/static-libs/lib/libnio.a > >> build/linux-x86_64-normal-server-release/images/static-libs/lib/libprefs.a > >> build/linux-x86_64-normal-server-release/images/static-libs/lib/libjava.a > >> build/linux-x86_64-normal-server-release/images/static-libs/lib/libjli.a > >> build/linux-x86_64-normal-server-release/images/static-libs/lib/libnet.a > >> build/linux-x86_64-normal-server-release/images/static- > libs/lib/libjimage.a > >> build/linux-x86_64-normal-server-release/images/static-libs/lib/libjaas.a > >> build/linux-x86_64-normal-server-release/images/static- > libs/lib/libfdlibm.a > >> build/linux-x86_64-normal-server-release/images/static-libs/lib/libj2gss.a > >> build/linux-x86_64-normal-server-release/images/static- > libs/lib/libsunec.a > >> build/linux-x86_64-normal-server-release/images/static-libs/lib/libjsig.a > >> build/linux-x86_64-normal-server-release/images/static- > libs/lib/libextnet.a > >> build/linux-x86_64-normal-server-release/images/static- > libs/lib/libverify.a > >> build/linux-x86_64-normal-server-release/images/static-libs/lib/libzip.a > >> > >> The reason for this is that FindFiles isn't available in JDK 11u. > > > > Since Christoph backported JDK-8189861 to jdk11u-dev, the patch now > > works as expected with FindFiles. > > Right, I get that on my build now. It would have been nice if you'd told > me to look for this in the first place before submitting the patch. > > Bug flagged for approval. > > > > > Thanks, > > Severin > > > > -- > Andrew :) > > Senior Free Java Software Engineer > Red Hat, Inc. (http://www.redhat.com) > > PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) > Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222
