Beautiful!

Cheers,
Mikael

> On Mar 19, 2020, at 9:16 AM, Magnus Ihse Bursie 
> <magnus.ihse.bur...@oracle.com> wrote:
> 
> On 2020-03-19 14:32, Erik Joelsson wrote:
>> Looks good.
>> 
>> (and doh on how easy it was to simplify!)
> 
> Yeah. I was so sure some m4 trickery was going to be needed. And all it took 
> was a second look and some clever thinking. :-)
> 
> /Magnus
>> 
>> /Erik
>> 
>> On 2020-03-19 01:38, Magnus Ihse Bursie wrote:
>>> The function UTIL_DEPRECATED_ARG_ENABLE has a wonky API, where the user is 
>>> supposed to repeat the argument twice in different ways. It is possible to 
>>> do without this strange mechanics.
>>> 
>>> Currently there are no uses of UTIL_DEPRECATED_ARG_ENABLE in open code. 
>>> However, functions like this is not really subject to normal dead-code 
>>> removal policy, since they tend to be used only for a transition period, 
>>> but they need to be present, since there will always be new options to 
>>> deprecate...
>>> 
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8241254
>>> WebRev: 
>>> http://cr.openjdk.java.net/~ihse/JDK-8241254-simplify-UTIL_DEPRECATED_ARG_ENABLE/webrev.01
>>> 
>>> /Magnus
> 

Reply via email to