On 3/23/20 1:15 PM, Magnus Ihse Bursie wrote:
On 2020-03-23 18:20, Jonathan Gibbons wrote:
On 3/23/20 7:32 AM, Erik Joelsson wrote:
On 2020-03-23 07:21, Jonathan Gibbons wrote:
On 3/23/20 6:06 AM, Erik Joelsson wrote:
The environment variable name JT_HOME is defined by Jtreg itself
so I think it makes sense to use that. Configure is still honoring
it, but run-test-prebuilt is not. We can of course use a different
variable name internally, but I don't really see the reason as
JT_HOME is the generally accepted one.
Would it help to migrate jtreg towards using JTREG_HOME, as a
preferred alternative to JT_HOME?
Yes, I think that would help. Didn't even consider that possibility.
/Erik
I'll put that change into jtreg, so that it is available in the next
update for jtreg.
Nice, thank you very much! When is that due? That is, should I hold
this patch and wait for the next jtreg, or should I find a temporary
solution until then?
/Magnus
-- Jon
My reading of the jtreg code is that JT_HOME is only used in the startup
script, and it does not require it to be set; it will figure it out if
needed. It is not required within the Java source code.
I'm thinking to change the script to use JTREG_HOME, JTREG_JAVA (instead
of JT_HOME, JT_JAVA), and that I will default these new names to the
values of the old names, as a backwards compatibility measure. I also
notice some inconsistent variations on the name in comments that I will
also fix.
Does this seem a reasonable approach?
-- Jon
