On 28/04/2020 12:02 pm, Michael Zucchi wrote:
Hi Severin,

On 27/4/20 6:17 pm, Severin Gehwolf wrote:
Hi Michael,

On Sat, 2020-04-25 at 09:39 +0930, Michael Zucchi wrote:
Morning all,

A patch from last year [1] discussed on this list adds an autoconf
fallback test for a shell builtin command using the bash command 'help
<command>' and invokes it for ulimit.  It's probably not very portable
to start with but bash can be compiled specifically without the help
command by passing --disable-help-builtin to configure.  guix uses this
option for it's build environment shell [4], hence openjdk fails to
configure there without a patch such as the one below.

For openjdk 14[3], is it possible to use a more portable sequence in the
BASIC_REQUIRE_BUILTIN_PROGS macro?   The internet [2] suggests using
"command -v <command>" or "type  <command>" for this purpose.

Although I have not tried, the same appears to apply to openjdk-15
although the macro has been moved to UTIL_REQUIRE_BUILTIN_PROGS in
make/autoconf/util.m4
Thanks for the report. I've filed this bug to track it:
https://bugs.openjdk.java.net/browse/JDK-8243656

I can sponsor the patch for you. Do you have the OCA signed?

Ok cheers.  No on the OCA.  I don't have direct access to a printer or scanner so I will have to run around to sort it out but I have plenty of spare time so will chase it up (assuming covid hasn't closed everything).

Simple changes like this do not require the OCA.

A Participant is an individual who has subscribed to one or more OpenJDK mailing lists. A Participant may post messages to a list, submit simple patches, and make other kinds of small contributions.

A Contributor is a Participant who has signed the Oracle Contributor Agreement (OCA), ...

http://openjdk.java.net/bylaws#participant

Cheers,
David

I can't see how this particular change includes any copyrightable creative input but I suppose that's up to the project to decide.

Regards,
  Michael


Reply via email to