On 2020-04-29 12:31, Alan Bateman wrote:
On 29/04/2020 10:27, Magnus Ihse Bursie wrote:
Due to the current design of the AddPackagesAttribute build tool, all
module-info.class files will be written to, when the tool is run.
This happens whenever at least one module-info.class file has been
updated. The end result of this is that if you recompile a single
module, *all* modules will be touch, forcing jmod to repackage all of
them.
This fix did not initially work, since the jmod generation was
non-deterministic, but that has gracefully been fixed by Alan in
JDK-8243666.
Bug: https://bugs.openjdk.java.net/browse/JDK-8243665
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8243665-fix-AddPackagesAttribute/webrev.01
The indentation should be 4 spaces rather than 2, otherwise the
Arrays.equals check looks okay.
Of course. Getting damaged from all the makefile nonsense. :)
Are you sure you want the "Writing to " noise?
Oops! No, that was just a debug message left over. How embarrassing! :)
New try:
http://cr.openjdk.java.net/~ihse/JDK-8243665-fix-AddPackagesAttribute/webrev.02
/Magnus
-Alan