Looks good.

/Erik

On 2020-05-15 09:24, Magnus Ihse Bursie wrote:
Unfortunately JDK-8245046 was not enough to be able to produce the Hotspot VS project file. With this patch, the generation has been tested and verified by one of our Windows developers.

Bug: https://bugs.openjdk.java.net/browse/JDK-8245119
Patch inline:
diff --git a/make/Main.gmk b/make/Main.gmk
--- a/make/Main.gmk
+++ b/make/Main.gmk
@@ -263,6 +263,7 @@
 $(eval $(call SetupTarget, hotspot-ide-project, \
     MAKEFILE := hotspot/ide/CreateVSProject, \
     DEPS := hotspot exploded-image, \
+    ARGS := -I$(TOPDIR)/make/hotspot, \
 ))

 ALL_TARGETS += $(HOTSPOT_VARIANT_TARGETS) $(HOTSPOT_VARIANT_GENSRC_TARGETS) \

/Magnus

Reply via email to