On 19/05/2020 12:39, Magnus Ihse Bursie wrote:
The main reason for this refactoring is to clear up all the "junk" that is spread out all over the make directories. Unfortunately, the "make" directory has, since historic times, been seen as a nice-to-have "misc" category where you can just put stuff willy-nilly and not care about the consequences. I've been working for a long time trying to get things a bit more organized. As such, I don't expect to see any particular gain for any specific IDE support implementation, but a gain for the general ability for the build system to be comprehensible, and to have a starting point for getting more and more integrated and improved support for a variety of IDEs for a variety of use cases.
I agree with this - I guess what I'm saying is that the improvement in readability of the build system in your v2 patch comes, IMHO from reorganizing the JDK-wide projects, and much less from trying to enforce structure on ad-hoc projects like the langtools ones, which still have dependencies on other make folders. That's my 0.02$ - as I said, I'm fine with the refactoring if you think that also moving the langtools files makes the world a better place.
Maurizio
