testing revealed that LingeredAppTest.java required some love, incremental webrev w/ the fixes for LingeredAppTest -- http://cr.openjdk.java.net/~iignatyev//8211977/webrev.0-1
-- Igor > On Jun 12, 2020, at 8:38 PM, Igor Ignatyev <igor.ignat...@oracle.com> wrote: > > adding build-dev > >> On Jun 12, 2020, at 8:36 PM, Igor Ignatyev <igor.ignat...@oracle.com> wrote: >> >> http://cr.openjdk.java.net/~iignatyev//8211977/webrev.00/ >>> 796 lines changed: 200 ins; 588 del; 8 mod; >> >> Hi all, >> >> could you please review this small patch which puts all tests for >> testlibrary classes into one location under /test/lib-test? >> >> besides moving tests from test/jdk/lib/testlibrary and >> test/hotspot/jtreg/testlibrary_tests to test/lib-test the patch also >> - problem lists HexPrinterTest.java on windows due to JDK-8247521 >> - introduces make targets to build native parts for the tests in >> test/lib-test (needed b/c one test has a native part) >> - adds randomness k/w to test/lib-test (as it's used by >> RandomGeneratorTest.java) >> - makes Test class used by TestNativeProcessBuilder a static nested class of >> TestNativeProcessBuilder >> - updates LingeredAppTest to use @build instead of @compile and adds >> necessary @library tag >> - removes AssertsTest.java, OutputAnalyzerTest.java from >> test/hotspot/jtreg/testlibrary_tests as they are either identical or lesser >> that the same tests from test/jdk/lib/testlibrary/ >> - merges test/hotspot/jtreg/testlibrary_tests/OutputAnalyzerTest.java and >> test/jdk/lib/testlibrary/OutputAnalyzerTest.java (effectively adds test >> cases for `firstMatch` to the superier copy from test/jdk/lib/testlibrary) >> >> webrev: http://cr.openjdk.java.net/~iignatyev//8211977/webrev.00/ >> JBS: https://bugs.openjdk.java.net/browse/JDK-8211977 >> testing: test/lib-test on {windows,linux,macosx}-x64 >> >> Thanks, >> -- Igor >> >> >
