Hi Magnus,
Great to see this getting fixed! Thanks!
On 16/06/2020 1:56 am, Magnus Ihse Bursie wrote:
It turned out that it was not possible to send arguments directly to the
java that launches jtreg, something that was needed, especially to
change the output limit using Djavatest.maxOutputSize.
This patch adds JTREG=LAUNCHER_OPTIONS=xxx to pass generic options to
the launcher.
Is there some special prefix handling going on here? The makefile lists
JTREG_LAUNCHER_OPTIONS as the variable. Without any other information
that is what I would set on the command-line.
Also, for the specific case of changing the max output
size, it adds JTREG=MAX_OUTPUT=nnn.
Is it worthwhile special-casing for max output? How would someone even
think to ask if such a special case exists? Typical scenario is that
someone sees the output overflow in a jtr file and the message to
increase -Djavatest.maxOutputSize, so they will then ask "how do I pass
a flag to jtreg?" and hopefully easily discover LAUNCHER_OPTIONS and use it.
All these new options made me realize there's no way apart from reading
the code to know what options are available, so I added a help system,
and documented this in "make help". Now you can get:
$ make test JTREG=help
Building target 'test' in configuration 'linux-x64'
Valid keywords for JTREG:
JOBS TIMEOUT_FACTOR FAILURE_HANDLER_TIMEOUT TEST_MODE ASSERT VERBOSE
RETAIN MAX_MEM RUN_PROBLEM_LISTS RETRY_COUNT MAX_OUTPUT OPTIONS
JAVA_OPTIONS VM_OPTIONS KEYWORDS EXTRA_PROBLEM_LISTS AOT_MODULES
LAUNCHER_OPTIONS.
RunTests.gmk:292: *** Re-run without 'help' to continue. Stop.
That's goods to see but it is unclear what form the values for these
keywords should take, or how to specify multiple keywords. How do we map
these keywords back to jtreg flags? I see Jon's separate thread on
documenting flags, so is the answer that jtreg docs will describe all this?
Thanks,
David
-----
Finally, I fixed some broken comments regarding AOT that I noticed while
fixing this.
Bug: https://bugs.openjdk.java.net/browse/JDK-8220639
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8220639-add-jtreg-launcher-options/webrev.01
/Magnus
