> On Jun 30, 2020, at 6:08 AM, Magnus Ihse Bursie > <magnus.ihse.bur...@oracle.com> wrote: > > Currently hotspot/share/utilities/globalDefinitions_visCPP.hpp contains a lot > of #pragma warning( disable : ...). > > All these globally disabled warnings should move to the make files instead. > > I also cleaned out some versions checks that are no longer relevant for the > range of supported versions of Microsoft Visual Studio. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8248548 > WebRev: > http://cr.openjdk.java.net/~ihse/JDK-8248548-use-DISABLED_WARNINGS_microsoft-for-hotspot/webrev.01 > > /Magnus
I think it would be nice to have a comment block describing each of the disabled warnings. But thanks for sorting them, unlike the globalDefinitions code. (Even better would be to have comments describing why we’re disabling them, but we don’t do that for any other platform either.)
