On 2020-06-30 14:11, Yasumasa Suenaga wrote:
Thanks Magnus!
We cannot build OpenJDK on Windows 10 May 2020 update even if we use
WSL 1.
So I will push this change when I got second reviewer.
The two-reviewer rule is only for hotspot code. Build changes only
requires one review, so you are good to go now.
I hope we can build OpenJDK on WSL 2, and I will help you if I can :)
I am curious what kind of performance you are getting. I experimented a
lot, but ran into several issues indicating that WSL2 was not mature
enough yet. But what was even more worrying was that I could not see any
performance gains compared to WSL1 or cygwin. :(
/Magnus
Yasumasa
On 2020/06/30 18:24, Magnus Ihse Bursie wrote:
On 2020-06-30 09:47, Yasumasa Suenaga wrote:
Hi all,
Please review this change.
This change is happen on discussion for WSL 2 support [1], but I
tested this change on WSL 1 (Ubuntu 20.04).
JBS: https://bugs.openjdk.java.net/browse/JDK-8248526
webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8248526/webrev.00/
Hi Yasumasa,
FYI, I have been working for a time on a major rewrite of the way we
handle Windows compilation, which will support cygwin, msys2, wsl1,
wsl2 and wine-on-linux, and doing all of this in a cleaner and much
more unified way than we currently do. However, this is far from
ready, and most likely I'll have to continue working with it after my
upcoming vacation. So in the meantime, if your fix solves the
immediate problems, I think we should take it in. The patch itself
looks good to me.
/Magnus
I saw two configure errors when I run configure script on WSL in
Windows 10 May 2020 update (See JBS for more details).
Since Windows 10 build 18945 [2], wslpath issue [3] has been fixed.
I guess this is the cause of wslpath problem in configure script.
Thanks,
Yasumasa
[1]
https://mail.openjdk.java.net/pipermail/build-dev/2020-June/027571.html
[2]
https://docs.microsoft.com/ja-jp/windows/wsl/release-notes#build-18945
[3] https://github.com/microsoft/WSL/issues/4078