Hi,
I think the idea of generating two distinct jars is workable, but I
really don't like the prospect of routinely having to move micros around
as the features they test promote from preview.
Would a manually managed list of which tests use --enable-preview work
for you? Not ideal either, but that would be less intrusive when taking
the feature out of preview along with removal of the flag from the micro
settings.
Also, I believe the INDIFY step to be an unfortunate piece of technical
debt which we don't need to carry over to a preview build step.
Thanks!
/Claes
On 2020-07-11 12:00, Peter Levart wrote:
On 7/11/20 9:31 AM, Peter Levart wrote:
- compile the two sets of benchmarks separately with separate output
directories and create separate benchmarks.jar files for them
Here's my attempt at a patch for separate benchmarks.jar files. The
minor complication, as I found out, was what to do when running the
micro benchmarks via "make test TEST=..." command when there are two
possible jar files to choose from. I opted for a separate tag in TEST
variable, so preview benchmark(s) are run as follows:
make test TEST="micro.preview: ..."
http://cr.openjdk.java.net/~plevart/jdk-dev/8248429_jmh_enable_preview/webrev.02/
WDYT?
Regards, Peter
