On 2020-08-13 19:40, Joe Darcy wrote:
Hello,

Ahead of the JDK switching to Git, please review the updates to the build docs:

    JDK-8251549: Update docs on building for Git
    http://cr.openjdk.java.net/~darcy/8251549.0/

This would be pushed shortly *after* the transition to Git.

Once the changes to md are agree to, I'll regenerate the companion html file.
My main question here is your recommendation to use https://gitforwindows.org. Have you verified that this works in all circumstances? The reason we had the entire paragraph was that this was certainly not true for mercurial -- if you used a version of hg that did not know about mercurial metadata, weird things started happen after a while. I think it was stuff like permissions being set and copied incorrectly, etc. Sometimes paths got messed up, like if you used symlinks etc. Unfortunately, I don't remember all details, but it tended to be a handful of edge cases with hard-to-debug failures each year.

So my gut reaction here is that we should keep this recommendation: use "git" from cygwin, instead of using a stand-alone version.

And if you have tested this thoroughly and show that gitforwindows seem to work, we do not keep those instructions in the list of special considerations for Windows at all.

/Magnus

Thanks,

-Joe


Reply via email to