On 31/08/2020 12:44, Severin Gehwolf wrote: > Sorry, wrong webrev. Now corrected. > > On Mon, 2020-08-31 at 10:02 +0200, Severin Gehwolf wrote: >> Hi, >> >> Could I get a reivew of this 8u specific bug please? When configured >> --with-native-debug-symbols=external,zipped the resulting external >> debuginfo files for binaries (in images/bin folder) aren't there. >> >> In OpenJDK 8u there is some special casing involved for bin/java and >> bin/unpack200. Thus, I had to special case them for the debuginfo >> variant files too otherwise those files would be missing in the images >> folders (j2sdk-image, j2re-image). >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8252395 > > webrev: https://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8252395/02/webrev/ > >> >> Testing: Build in configs >> --with-native-debugsymbols={zipped,external,internal,none} >> on Linux x86 and manually debugging some launcher code. Works now >> with symbols. Symbols were missing before this patch.
OK. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. <https://www.redhat.com> https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
