On Wed, 2020-09-09 at 14:26 -0400, Zhengyu Gu wrote:
> Verified, it fixed build. Looks good to me.
>
> Thanks for the quick fix.
Thanks for the review!
Cheers,
Severin
> -Zhengyu
>
> On 9/9/20 2:16 PM, Severin Gehwolf wrote:
> > Hi,
> >
> > Please review this 8u (jdk8u/jdk8u-dev tree) fix for JDK-8252395 that
> > I've pushed today. Thanks for Zhengyu Gu for noticing it. The pushed
> > fix added the java.debuginfo and unpack.debuginfo make targets on the
> > condition of ENABLE_DEBUG_SYMBOLS=true, which is insufficient. It needs
> > another check on POST_STRIP_CMD which is set to non-empty for --with-
> > native-debug-symbols={external,zipped}, and is indeed empty for --with-
> > native-debug-symbols=internal. For the --with-native-debug-symbols=none
> > case we have ENABLE_DEBUG_SYMBOLS=false.
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8252975
> > webrev: https://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8252975/01/webrev/
> >
> > Testing: Builds with
> > --with-native-debug-symbols={none,internal,external,zipped} on Linux x86_64
> >
> > OK?
> >
> > Thanks,
> > Severin
> >
