Hi Monica, On 11/09/2020 3:11 am, Monica Beckwith wrote:
Ref: https://github.com/openjdk/jdk/pull/97#issuecomment-690077743 Hi David, Thanks. I wanted to start a conversation here as it does modify common code (the aarch64-linux combo check) and also wanted to highlight the difference between Shenandoah and ZGC checks. IMHO, Shenandoah checks are cleaner and if people agree, I would like to apply those to ZGC as well. (When that happens, it *will* be outside of the windows-aarch64 port and I will change the info in JBS accordingly) Please let me know what you think.
I think you are going about this in a bit of a confusing way :) If you wanted to propose the ZGC feature check should be OS agnostic then you should have just proposed that rather than proposing a Windows-Aarch64 change that clearly belongs with the port work. You'll need to discuss the ZGC check with the ZGC folk on hotspot-gc-dev (now cc'd) but I'm pretty sure the OS check is deliberate, so that only those platforms known to actually work will be enabled.
Thanks, David
------------- PR: https://git.openjdk.java.net/jdk/pull/97
