On Mon, 26 Oct 2020 18:53:53 GMT, John Paul Adrian Glaubitz 
<[email protected]> wrote:

>> I realized that JDK-8254282 missed "Linux x32" for the platform selection. 
>> While you can guess it is accepted from reading the workflow, it would be 
>> more convenient to have it in the default argument list.
>
> Note that "Linux x32" is ambigious as this is the name for the x32 ABI 
> (x86_64 with 32-bit pointers).

I agree with @glaubitz; "x32" is an odd choice of name for what we've been 
calling "x86" in the JDK build all the time.

I realize this unfortunate naming arrived with JDK-8254282, which I 
unfortunately was too late to review. However, I'd very much want to request 
the "x32" naming changed to "x86" consistently in submit.yml. This relates to 
JDK-8255305 as well. And frankly, I don't understand why this is a separate 
bug, instead of a part of JDK-8255305. Can you please explain the rationale for 
that? If you just want to make additional changes to JDK-8255305, there is 
really no need to open a new JBS issue and PR -- just push additional commits 
to JDK-8255305!

-------------

PR: https://git.openjdk.java.net/jdk/pull/869

Reply via email to