On Mon, 2 Nov 2020 15:41:06 GMT, Magnus Ihse Bursie <[email protected]> wrote:
>> Thank you Andrew.
>
> @lewurm
> This patch seems to break on linux-aarch64 with gcc:
> open/src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp:1501:52: error:
> comparison of integer expressions of different signedness: 'size_t' {aka
> 'long unsigned int'} and 'int' [-Werror=sign-compare]
> 1501 | assert(StackOverflow::stack_shadow_zone_size() ==
> (int)StackOverflow::stack_shadow_zone_size(), "must be same");
> |
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Did you test building this on any aarch64 platforms besides Windows?
@magicus I did test the initial version of this PR on linux+arm64, but not the
latest iteration. sorry about that 🙁
What is the policy here? Submit a revert right away or investigate a fix?
-------------
PR: https://git.openjdk.java.net/jdk/pull/530
