On Tue, 3 Nov 2020 18:30:46 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> Add 32-bit-safe version of jlong <-> casts to libJNIPoint.c >> >> This removes the reported warning. >> >> Note that the _LP64 macro was not being propagated to the benchmark native >> libraries on Windows. The comment says that this is due to pack200, but >> since this has been removed [1], it seemed safe to propagate the macro now >> (backed up by testing). >> >> CC'ing hotspot-runtime since I know some people there were looking forward >> to having this fixed. >> >> Testing: tier1-3 >> >> [1] https://bugs.openjdk.java.net/browse/JDK-8232022 > > I knew this looks familiar. Look at [existing macros in > jlong_md.h](https://github.com/openjdk/jdk/blob/master/src/java.base/unix/native/libjava/jlong_md.h#L67-L81) > and use/match them? There is a little difference in casting through `jint` > in your code, while `jlong_md.h` does it via `int`. @shipilev Now that I look at the file you linked, it does look familiar to me as well. Must have copy-pasted it from my subconscious ;) Looks like this file is usable from the benchmark lib code as well, will try to switch. ------------- PR: https://git.openjdk.java.net/jdk/pull/1017
