On Wed, 4 Nov 2020 13:40:49 GMT, Erik Joelsson <er...@openjdk.org> wrote:

>> Current submit workflow omits `hs_err*.log` and `replay*.log` files, because 
>> zip matches the paths, and so only the hs_errs/replays in the current dir 
>> are picked up (and there are none). It should be preceded with `*` to match 
>> files in subdirs. Incidentally, this is why `*.jtr` match works.
>> 
>> Observe:
>> 
>> $ mkdir 1/2 -p
>> $ touch 1/2/hs_err_213123.log
>> $ zip -r9 test.zip . -i hs_err*
>>      zip warning: zip file empty
>> $ zip -r9 test.zip . -i */hs_err*
>>   adding: 1/2/hs_err_213123.log (stored 0%)
>> 
>> This was introduced in the initial implementation in JDK-8255352.
>> 
>> Additional testing:
>>  - [x] Observing current Windows failures package hs_err into archive
>
> Marked as reviewed by erikj (Reviewer).

Thank you, @erikj79. Trivial? (I would like to get is soon, in order to capture 
more hs_errs for current failures)

-------------

PR: https://git.openjdk.java.net/jdk/pull/1055

Reply via email to