On Mon, 23 Nov 2020 11:37:14 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> This is incorrect. The `-l` prefix indicates a library to link with. As >> such, it belongs to LIBS, not LDFLAGS. >> >> I'm not sure if we still have a global LIBS variable that is added to all >> compile lines. We used to have since Solaris Studio required `-lc` for every >> non-trivial file, but it might have been purged with the Solaris platform. >> >> Otherwise this looks like something that belong in LIBJVM LIBS. In fact, if >> it is *only* needed for the hotspot build, it is really where it belong. And >> even if it's needed in an additional library or two, it should be added on >> those places. Only if like more or less all libraries require this should it >> be added as a global flag. > >> Otherwise this looks like something that belong in LIBJVM LIBS. In fact, if >> it is _only_ needed for the hotspot build, it is really where it belong. And >> even if it's needed in an additional library or two, it should be added on >> those places. Only if like more or less all libraries require this should it >> be added as a global flag. > > So, would adding to `BASIC_JVM_LIBS` at `LIB_SETUP_LIBRARIES` step in > `make/autoconf/libraries.m4` be a good place then? @shipilev Looks like you found the place! :-) But make sure to build all the JDK libraries as well, to see if it is needed by elsewhere as well. ------------- PR: https://git.openjdk.java.net/jdk/pull/1375
