On Mon, 23 Nov 2020 12:37:47 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

>> .github/workflows/submit.yml line 1367:
>> 
>>> 1365:           git apply p.patch
>>> 1366:         working-directory: jdk
>>> 1367:         shell: bash
>> 
>> This should be in the mainline repo instead. Yes, the absence of this patch 
>> blocks this PR, but getting that patch into the mainline first is the right 
>> thing to do.
>
> I agree. We should not have a build action that requires a patch.

That patch in its current form is not suitable for upstream.

The initial plan was to wait until the "new WINENV" patch lands [1], which 
would resolve the problem we face with `fixpath.exe`. But maybe I can come up 
with a solution for the current situation, given that I've a better 
understanding of the build system by now.


[1] https://mail.openjdk.java.net/pipermail/build-dev/2020-July/027872.html

-------------

PR: https://git.openjdk.java.net/jdk/pull/1379

Reply via email to