On Mon, 23 Nov 2020 15:55:43 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> I think a proper solution to both this and the Capstone implementation is to >> provide a proper framework for selecting the hsdis backend as a first step, >> and refactor the existing bfd implementation as the first such backend. >> After that, we can add llvm and capstone as alternative hsdis backend >> implementations. > > FWIW, I started working on a framework which would add support for selectable > backends for hsdis. Unfortunately it was not as simple as I initially > thought, so I had to put it on hold while directing my time to working on the > winenv patch instead. > > I believe the proper way forward is to get the "selectable hsdis backend" > framework in place, and then retrofit this patch to add LLVM support in that > framework. If this means that this PR should be closed, or kept open until > this is done, I don't know. Nag nag bot... I'm away for the holidays now, but I intend to pick up the work on the selectable hsdis backend when I return. So while this exact code is unlikely to be the one merged, it's good to have it open to allow me to double check the solutions picked here. ------------- PR: https://git.openjdk.java.net/jdk/pull/392