On Wed, 23 Dec 2020 05:10:31 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
>> Yoshiki Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 5th: 8258460: Remove --doclint-format option from javac > > One must-fix item (bad pattern constant.) \s was introduced as a valid escape character in JDK 15 as part of the support for Text Blocks. https://docs.oracle.com/javase/specs/jls/se15/html/jls-3.html#jls-EscapeSequence https://docs.oracle.com/javase/specs/jls/se14/preview/specs/text-blocks-jls.html#jls-3.10.7 FWIW, the escape sequence showed up with red squiggly lines in my IDE. -- Jon On 12/22/20 9:38 PM, Yoshiki SATO wrote: > > *@satoyoshiki* commented on this pull request. > > ------------------------------------------------------------------------ > > In > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java > <https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/893*discussion_r547668049__;Iw!!GqivPVa7Brio!OUEFldgNdIV8aqoReM0lNXfIYO3IoXGR1RUbcYmVdEHRRdA3oy1Zaa3h2DevZiYojsWrqg$>: > > > @@ -765,8 +732,8 @@ private Element getEnclosingPackageOrClass(Element e) { > return e; > } > > - //http://www.w3.org/TR/html401/types.html#type-name > <https://urldefense.com/v3/__http://www.w3.org/TR/html401/types.html*type-name__;Iw!!GqivPVa7Brio!OUEFldgNdIV8aqoReM0lNXfIYO3IoXGR1RUbcYmVdEHRRdA3oy1Zaa3h2DevZibVYnjqnQ$> > - private static final Pattern validName = > Pattern.compile("[A-Za-z][A-Za-z0-9-_:.]*"); > + //https://html.spec.whatwg.org/#the-id-attribute > <https://urldefense.com/v3/__https://html.spec.whatwg.org/*the-id-attribute__;Iw!!GqivPVa7Brio!OUEFldgNdIV8aqoReM0lNXfIYO3IoXGR1RUbcYmVdEHRRdA3oy1Zaa3h2DevZib5vw0eRg$> > + private static final Pattern validId = Pattern.compile("[^\s]+"); > > Correct. Thanks a lot for finding this error. > Now that I have doubts why this line could have been compiled without > error. This line should cause a compiler error. > > Let me review all anchor tests again because the logic should be > checked there. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/893*discussion_r547668049__;Iw!!GqivPVa7Brio!OUEFldgNdIV8aqoReM0lNXfIYO3IoXGR1RUbcYmVdEHRRdA3oy1Zaa3h2DevZiYojsWrqg$>, > > or unsubscribe > <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AOUXBRXCJBCNZR4ZUBZCEBTSWF66TANCNFSM4TBXTH2Q__;!!GqivPVa7Brio!OUEFldgNdIV8aqoReM0lNXfIYO3IoXGR1RUbcYmVdEHRRdA3oy1Zaa3h2DevZia6kQL08w$>. > ------------- PR: https://git.openjdk.java.net/jdk/pull/893
