On Tue, 5 Jan 2021 18:35:07 GMT, Vladimir Kozlov <k...@openjdk.org> wrote:
>> Hao Sun has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update the copy constructors for class DUIterator, DUIterator_Fast and >> DUIterator_Last >> >> 1. Update copyright year to 2021. >> 2. Add the definition of copy constructor for class DUIterator. >> Otherwise, gcc with '-fno-elide-constructors' would raise a warning. >> 3. For the copy constructor of class DUIterator_Fast, we initialize >> '_vdui' as false, otherwise UB is introduced. >> 4. It's better to define the copy constructor of class DUIterator_Last >> as explicitly-defaulted, instead of leaving it for compilers to >> implicitly define. >> >> Change-Id: I3d2f5b396aa116d1832f52da361ff3172459a87e >> CustomizedGitHooks: yes > > node.hpp changes seems fine. > Passed tier1 builds and testing. > > I think the two issues described here are distinct and should be dealt > > with in separate bugs and PRs. Their only relation is that both arise > > with using clang-10. But they are very different problems, in very > > different parts of the code, and probably ought to be reviewed by > > folks from different teams. > > Thanks for your comment. > > Warning message of '-Wimplicit-int-float-conversion' was further encountered > after we fixed the build failure caused by '-Wdeprecated-copy' first. That's > why we put them in one PR initially. > > Yes. Your way is much better. But we suppose the issue of > '-Wimplicit-int-float-conversion' is trivial and putting them in separate PRs > might raise another internal review process (for our side) by which extra > time is needed. I was wondering could we continue in one single PR. :) Will split this PR. In this PR, we focus on the warnings caused by -Wdeprecated-copy. Will update the code soon. Will create a new PR to address JDK-8259288. ------------- PR: https://git.openjdk.java.net/jdk/pull/1874
