On Tue, 12 Jan 2021 02:31:56 GMT, Sergey Bylokhov <[email protected]> wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8259343: [macOS] Update JNI error handling in Cocoa code.
>
> src/java.desktop/macosx/native/libosxapp/JNIUtilities.h line 197:
>
>> 195: } \
>> 196: if (getenv("JNU_NO_COCOA_EXCEPTION") == NULL) { \
>> 197: [NSException raise:NSGenericException format:@"Java
>> Exception"]; \
>
> How did you check that the logging in the NSApplication was swallowing? Both
> macro will throw the NSException on the toolkit thread now, does it mean that
> in both cases the logging in the NSApplication will be ignored/no output?
See the bug assigned to you that I filed last month :
https://bugs.openjdk.java.net/browse/JDK-8258797
This error should have been logged by that NSApplicationAWT code but was not
(and I mean in JDK 16 as well before I started on this) and in JDK 17 it was
seen only when adding the new logging.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1967
