On Mon, 25 Jan 2021 13:08:53 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> A problem was found downstream with Eclipse OpenJ9 builds whereby since >> JDK-8258411 they were unable to extend the module lists. >> This PR adds a IncludeCustomExtension to the conf/module-loader-map.conf, to >> enable the module list extension again. >> >> Signed-off-by: Andrew Leonard <anleo...@redhat.com> > > make/conf/module-loader-map.conf line 100: > >> 98: # Hook to include the corresponding custom file, if present. >> 99: $(eval $(call IncludeCustomExtension, conf/module-loader-map.conf)) >> 100: > > Using IncludeCustomExtension is a good idea, but you should to this where > module-loader-map.conf is included in common/Modules.gmk, not here. The > `*.conf` files are supposed to be formatted as simple configuration files, > and not include special make commands. @magicus Is there an ordering issue in common/Modules.gmk? It also invokes IncludeCustomExtension but this is done before it includes the conf file. ------------- PR: https://git.openjdk.java.net/jdk/pull/2219
