On Mon, 25 Jan 2021 20:54:38 GMT, Vladimir Kempik <[email protected]> wrote:
>> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 573:
>>
>>> 571: EXTRA_HEADER_DIRS := $(LIBFONTMANAGER_EXTRA_HEADER_DIRS), \
>>> 572: WARNINGS_AS_ERRORS_xlc := false, \
>>> 573: DISABLED_WARNINGS_clang := deprecated-declarations, \
>>
>> I see this added here and in another location. What is deprecated ? You
>> really need to explain these sorts of things.
>> I've built JDK using Xcode 12.3 and not had any need for this.
>
> Hello
> I believe it was a workaround for issues with xcode 12.2 in early beta days.
> Those issues were fixed later in upstream jdk, so most likely we need to
> remove these workarounds.
It seems these workarounds are still needed:
jdk/src/java.desktop/macosx/native/libsplashscreen/splashscreen_sys.m:300:39:
error: 'NSAlphaFirstBitmapFormat' is deprecated: first deprecated in macOS
10.14 [-Werror,-Wdeprecated-declarations]
bitmapFormat: NSAlphaFirstBitmapFormat |
NSAlphaNonpremultipliedBitmapFormat
^~~~~~~~~~~~~~~~~~~~~~~~
NSBitmapFormatAlphaFirst
jdk/src/java.desktop/macosx/native/libsplashscreen/splashscreen_sys.m:438:34:
error: 'NSBorderlessWindowMask' is deprecated: first deprecated in macOS 10.12
[-Werror,-Wdeprecated-declarations]
styleMask: NSBorderlessWindowMask
^~~~~~~~~~~~~~~~~~~~~~
NSWindowStyleMaskBorderless
-------------
PR: https://git.openjdk.java.net/jdk/pull/2200