On Tue, 2 Feb 2021 21:26:28 GMT, Kevin Rushforth <k...@openjdk.org> wrote:

>> The changes look good to me, but please see my comment from my review about 
>> documenting `NormalizedPathNSStringFromJavaString()` API.
>
> The following commit was integrated to jdk master since you created this 
> branch:
> 
> acbcde8 : [JDK-8256111](https://bugs.openjdk.java.net/browse/JDK-8256111) : 
> Create implementation for NSAccessibilityStaticText protocol
> 
> with a new reference to JNF, so it fails to compile with this patch. You will 
> need to merge openjdk/jdk master into your PR branch and then fix the new JNF 
> reference.

Updated as follows
- merged to current master and fixed the new A11Y usage of JNF
- added comment provided by Gerard
- removed comments as suggested by Sergey
- made failure of GetStringChars in CTextPipe throw OOME

-------------

PR: https://git.openjdk.java.net/jdk/pull/2305

Reply via email to