On Tue, 30 Mar 2021 11:44:29 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> make/conf/jib-profiles.js line 456:
>>
>>> 454: configure_args: concat(common.configure_args_64bit,
>>> "--with-zlib=system",
>>> 455: "--with-macosx-version-max=11.00.00",
>>> 456: "SETFILE=/usr/bin/SetFile"),
>>
>> "SetFile" from the devkit still does not work on the latest macOS?
>
> I'm a bit surprised at this myself. If it is needed, I will accept this
> patch, but then I think we need to fix that properly and submit a follow-up
> patch.
>
> I also note that on macos-x64 we add `--enable-compatible-cds-alignment` as
> well. I wonder if we should not do that here as well..? (Although I must
> admit I did not fully understand when and how the CDS alignment rules
> applied.)
I don't think we need to set SETFILE anymore. This used to be needed because
the SetFile binary in older Xcode versions was 32 bit and Catalina no longer
supports 32 bit apps. This should definitely not be a problem on aarch64.
>> make/conf/jib-profiles.js line 1049:
>>
>>> 1047: var devkit_platform_revisions = {
>>> 1048: linux_x64: "gcc10.2.0-OL6.4+1.0",
>>> 1049: macosx: "Xcode12.4+1.0",
>>
>> XCode bump w/o check for aarch?
>
> This seems to be used at line 1133 where 11.3.1 is hard-coded for x64. So I
> guess it works but I'm not very fond of this solution. @vidmik Why don't you
> put both x64 and aarch64 revisions here?
As I understand it, the intention is to bump the Xcode version for x64 as well,
though I must say I would prefer that change to go in separately.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3258
