On Tue, 30 Mar 2021 16:29:49 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Anton Kozlov has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits since the last revision: >> >> - Specify Xcode version; don't use --extra-{c,cxx,ld}flags >> - Merge remote-tracking branch 'upstream/jdk/master' into >> 8263856-gha-macos-aarch64 >> - Add macos/aarch64 build workflow > > .github/workflows/submit.yml line 1444: > >> 1442: --with-conf-name=macos-aarch64 >> 1443: --openjdk-target=aarch64-apple-darwin >> 1444: --with-extra-cflags="-arch arm64" > > If configure isn't adding these flags automatically, that's something that we > should fix. Thanks for review! The problem with flags is resolved by merging in master with https://bugs.openjdk.java.net/browse/JDK-8264650 The Xcode version if fixed to 12.4, which is consistent with the current state of PR #3258 (https://bugs.openjdk.java.net/browse/JDK-8264224) ------------- PR: https://git.openjdk.java.net/jdk/pull/3270