On Tue, 22 Jun 2021 10:30:28 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

> The test should really be on as version, but I agree that it does not seem 
> worth the hassle to add another version check, when in practice ld and as are 
> bundled together as binutils.
> 
> However, I would appreciate a comment clarifying this. I added a suggestion, 
> feel free to use it or modify it. Apart from this it looks good, so I'll 
> approve it.

Thanks for the feedback,  adding some words about as version makes of course a 
lot of sense, I adjusted the comment a bit.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4548

Reply via email to