> Hi, > > Could I have a review of this improvement that eliminates 'is_large' check if > the event size range is certain? > > JDK-8246260 introduced event large checks to reduce the recording size. > This check could be eliminated at compile/build time when one of the > following conditions is satisfied: > 1. if the max size is < 128 > 2. if the min size is >= 128 > > The max size and the min size could be computed for the most native events at > the generation phase. > > And I think this improvement may also be done for JDK events.
Denghui Dong has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: refactor ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/4670/files - new: https://git.openjdk.java.net/jdk/pull/4670/files/fa8c16cb..e8fdcb54 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4670&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4670&range=02-03 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/4670.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/4670/head:pull/4670 PR: https://git.openjdk.java.net/jdk/pull/4670
