On Thu, 15 Jul 2021 06:30:24 GMT, Aleksey Shipilev <sh...@openjdk.org> wrote:
>> LoongArch is a new RISC ISA. This issue proposes adding Zero support for
>> LoongArch. Only 64-bit support is proposed at present.
>>
>> linux-loongarch64-zero-{release, fastdebug} build tested:
>>
>> $ ./build/linux-loongarch64-zero-fastdebug/jdk/bin/java -version
>> openjdk version "18-internal" 2022-03-15
>> OpenJDK Runtime Environment (fastdebug build 18-internal+0-adhoc.aoqi.jdk)
>> OpenJDK 64-Bit Zero VM (fastdebug build 18-internal+0-adhoc.aoqi.jdk,
>> interpreted mode)
>
> src/hotspot/os/linux/os_linux.cpp line 1701:
>
>> 1699: {EM_AARCH64, EM_AARCH64, ELFCLASS64, ELFDATA2LSB,
>> (char*)"AARCH64"},
>> 1700: {EM_RISCV, EM_RISCV, ELFCLASS64, ELFDATA2LSB,
>> (char*)"RISC-V"},
>> 1701: {EM_LOONGARCH, EM_LOONGARCH, ELFCLASS64, ELFDATA2LSB,
>> (char*)"LoongArch"},
>
> Suggestion:
>
> {EM_LOONGARCH, EM_LOONGARCH, ELFCLASS64, ELFDATA2LSB,
> (char*)"LoongArch"},
I added some additional whitespaces according to EM_MIPS_RS3_LE line, which is
also too long. Your suggestion is fine to me. I will fix it.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4787
