On Fri, 27 Aug 2021 13:14:52 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> JDK-8272700 was created to fix a bug in a variable assignment in configure. >> While it fixed the bug, it kept the problematic syntax that caused the bug >> in the first place. >> >> We do not use the `FOO+="appended"` syntax for appending to variables in >> shell scripts, since this differs from what you'd expect (and what make >> produces) in that no space is added before the appended text. >> >> Instead, we use the longer, but clearer `FOO="$FOO appended"`. > > Magnus Ihse Bursie has updated the pull request incrementally with one > additional commit since the last revision: > > Fix code review comments I wouldn't have considered the m4 files as "shell scripts" and I'm surprised that the same operator in makefiles adds extra spaces - that seems unintuitive. But using the expanded format is fine. Thanks, David ------------- Marked as reviewed by dholmes (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5276
