On Thu, 23 Sep 2021 11:54:06 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Drop GH link > > doc/testing.html line 72: > >> 70: <p>The test specifications given in <code>TEST</code> is parsed into >> fully qualified test descriptors, which clearly and unambigously show which >> tests will be run. As an example, <code>:tier1</code> will expand to >> <code>jtreg:$(TOPDIR)/test/hotspot/jtreg:tier1 >> jtreg:$(TOPDIR)/test/jdk:tier1 jtreg:$(TOPDIR)/test/langtools:tier1 >> jtreg:$(TOPDIR)/test/nashorn:tier1 jtreg:$(TOPDIR)/test/jaxp:tier1</code>. >> You can always submit a list of fully qualified test descriptors in the >> <code>TEST</code> variable if you want to shortcut the parser.</p> >> 71: <h3 id="common-test-groups">Common Test Groups</h3> >> 72: <p>In the ideal world, contributors would be advised to run all the >> tests for every change. But in real world, one could only be expected to run >> as many tests as practical, while being mindful of the scope for the change, >> the testing resources available, etc.</p> > > A suggestion here is to start with something like "Ideally, all tests are run > for every change but this may not be practical. Contributors are expected to > at least run tier1 (see below) and the tests for the areas that are changed." Added a version of that, thanks. ------------- PR: https://git.openjdk.java.net/jdk/pull/5615
