On Fri, 5 Nov 2021 19:20:10 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Andrew Leonard has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
> make/modules/jdk.javadoc/Gendata.gmk line 75:
>
>> 73: $(call MakeTargetDir)
>> 74: $(call LogInfo, Creating javadoc element lists)
>> 75: $(RM) $(ELEMENT_LISTS_DIR)/element-list-{$(call CommaList,$(call
>> sequence,$(GENERATE_SYMBOLS_FROM_JDK_VERSION),$(JDK_SOURCE_TARGET_VERSION)))}.txt
>
> Good to see that it worked! I would only wish that you found a way to break
> up the line. Long lines make future side-by-side reviews and 3-way merges
> hard. We don't enforce strict 80, but try to stay in some reasonable ballpark
> in the build files.
>
> I think both CommaList and sequence are ok with whitespace in their
> parameters. Otherwise you could pre-calculate the numbers list in a variable
> before the recipe.
yep, i'll have a look to see what I can do, not helped with existing variables
being so long!! (GENERATE_SYMBOLS_FROM_JDK_VERSION)
-------------
PR: https://git.openjdk.java.net/jdk/pull/6278
