On Wed, 10 Nov 2021 14:39:09 GMT, Erik Joelsson <er...@openjdk.org> wrote:

>> @erikj79 The flag --enable-reproducible-builds sets 
>> ENABLE_REPRODUCIBLE_BUILD in spec.gmk. This is set by our JIB profiles. I 
>> propose that we also turn it on for GHA builds. 
>> 
>> I think that the post-processing of the zip file can be dependent on this 
>> variable and that it serves no purpose to introduce a separate variable 
>> ENABLE_REPRODUCIBLE_ZIP that is set to the same value as 
>> ENABLE_REPRODUCIBLE_BUILD. Do you agree?
>
>> I think that the post-processing of the zip file can be dependent on this 
>> variable and that it serves no purpose to introduce a separate variable 
>> ENABLE_REPRODUCIBLE_ZIP that is set to the same value as 
>> ENABLE_REPRODUCIBLE_BUILD. Do you agree?
> 
> Sure, that works for me.

@erikj79 all tests pass, ready for re-review please, thanks

-------------

PR: https://git.openjdk.java.net/jdk/pull/6311

Reply via email to