On Fri, 12 Nov 2021 08:24:13 GMT, Andrew Leonard <aleon...@openjdk.org> wrote:

>> This PR adds a new openjdk build tool MakeZipReproducible, which if 
>> ENABLE_REPRODUCIBLE_BUILD is enabled, generates a final "zip" file in a 
>> deterministic way, ensuring ordering and timestamps are set as specified.
>> 
>> Using this tool in ZipArchive.gmk will ensure src.zip is then created 
>> deterministically.
>> 
>> Signed-off-by: Andrew Leonard <anleo...@redhat.com>
>
> Andrew Leonard has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   8276743: Make openjdk build Zip Archive generation "reproducible"
>   
>   Signed-off-by: Andrew Leonard <anleo...@redhat.com>

I think it looks good now. Let Erik have a final say also, before integrating. 

Thank you for your effort!

-------------

Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6311

Reply via email to