On Mon, 15 Nov 2021 13:19:56 GMT, Yasumasa Suenaga <ysuen...@openjdk.org> wrote:
>> hsdis requires binutils source tree for building. Most of Linux distros >> provide binutils package. (e.g. binutils-devel from Fedora, binutils-dev >> from Ubuntu) >> It would be nice to be able to use them like zlib and lcms. >> >> Unfortunately bfdver.h would not be provided because it is not included >> install files (`make install`) in binutils. So I changed to use >> `SEC_ELF_OCTETS` macro to detect binutils version because it was introduced >> at the same time as `bfd_octets_per_byte()`. >> >> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;f=bfd/bfd-in2.h;h=618265039f697eab9e72bb58b95fc2d32925df58 >> >> Please see [JDK-8244819](https://bugs.openjdk.java.net/browse/JDK-8244819) >> why we need version check. > > Yasumasa Suenaga has updated the pull request incrementally with one > additional commit since the last revision: > > Refactoring Looks good to me now ------------- Marked as reviewed by ihse (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6378
