On Fri, 17 Dec 2021 09:18:03 GMT, Andrew Leonard <aleon...@openjdk.org> wrote:

> If "reproducible build" is enabled, then utilize the new --date option in the 
> building of jar's and jmods.
> Validating the boot jdk supports --date for the building of the jars.
> 
> Signed-off-by: Andrew Leonard <anleo...@redhat.com>

make/common/MakeBase.gmk line 145:

> 143: # If reproducible builds are enabled then set SOURCE_DATE_ISO_8601 
> string variable
> 144: ifeq ($(ENABLE_REPRODUCIBLE_BUILD), true)
> 145:   SOURCE_DATE_ISO_8601 := $(shell $(DATE) --utc 
> --date="@$(SOURCE_DATE_EPOCH)" +"%Y-%m-%dT%H:%M:%SZ" 2> /dev/null)

This should be set up by the configure script. Look for where we are currently 
doing the SOURCE_DATE_EPOCH stuff.

Also consider the possibility to *just* use this variable, and pass it on to 
jar if it is present, and not if it's missing. That way you can get rid of the 
redundant boolean variable.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6878

Reply via email to