On Sat, 8 Jan 2022 02:00:27 GMT, Yasumasa Suenaga <ysuen...@openjdk.org> wrote:
> [JDK-8277089](https://bugs.openjdk.java.net/browse/JDK-8277089) (PR #6378 ) > introduced the feature to build hsdis with binutils which is provided by the > system, however it may not work when it was build with --with-binutils=system. > > We can see the following message when the problem happens. I saw it on Ubuntu > 20.04. > > > hsdis: bad native mach=architecture not set in Makefile!; please port hsdis > to this platform > > > The cause is `-DLIBARCH_$OPENJDK_TARGET_CPU_LEGACY_LIB` is not set in > `HSDIS_CFLAGS`. For example, it will be set `LIBARCH_amd64` on AMD64. We > should set `LIBARCH_$OPENJDK_TARGET_CPU_LEGACY_LIB` to `HSDIS_CFLAGS` even if > the builder uses system binutils. This pull request has now been integrated. Changeset: 2f7665b8 Author: Yasumasa Suenaga <ysuen...@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/2f7665b8292cc09574d62fecc3e9619c488ac137 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod 8279644: hsdis may not work when it was built with --with-binutils=system Reviewed-by: erikj ------------- PR: https://git.openjdk.java.net/jdk/pull/6997
