On Mon, 3 Jan 2022 13:57:59 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Tyler Steele has refreshed the contents of this pull request, and previous >> commits have been removed. Incremental views are not available. > > Build changes look ok. You will also need ok from someone in the component > team. > @erikj79 Regarding the TOC warning I mentioned above: > > * I now believe the TOC warning has been present while building the master > branch (so this PR probably isn't the root cause). > * I've also noticed that the addition of `-qpic=large` in > [flags-cflags.m4](https://github.com/backwaterred/jdk/blob/79bfca43a729675da9c95a59fead373f76e9feac/make/autoconf/flags-cflags.m4#L429) > hasn't removed the build warning about a TOC overflow. > > For the above reasons, I've removed `-qpic=large` from the line linked above. I can't really comment on any AIX specific compiler flags as I'm not familiar with AIX and not representing a company that supports it. All I can say is that the build changes look sane from a structural point of view. I don't know if anyone here is able to judge the choice of AIX specific flags better than yourself. ------------- PR: https://git.openjdk.java.net/jdk/pull/6885
