On 1/24/22 8:43 AM, Thomas Stüfe wrote:
We generally build without --disable-precompiled-headers in GHAs, which
hides errors from missing includes. Since GHAs are very useful to test
builds on side platforms, would it not make sense to build without
precompiled headers? Or is that too costly?

But... We *do* build Hotspot without PCH in "additional" configurations that 
test different platforms:

https://github.com/openjdk/jdk/blob/9bf6ffa19f1ea9efcadb3396d921305c9ec0b1d1/.github/workflows/submit.yml#L408-L432

--
Thanks,
-Aleksey

Reply via email to