On Fri, 21 Jan 2022 09:28:27 GMT, Martin Doerr <mdo...@openjdk.org> wrote:
>> Tyler Steele has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Revert changes to jfrThreadSampler.cpp >> - Update copyright years. Remove 'TODO' where no longer needed. > > Thanks for enhancing libperfstat_aix and making it consistent. > I just noticed that JavaThread::pd_get_top_frame_for_profiling does not yet > contain all the required checks. I think they should be taken from > thread_linux_ppc.cpp (note that there were recent fixes). > Thanks for your comments @TheRealMDoerr. I agree that 131 files changed is > too many to review; most of them are not files I actually changed, so I will > do some digging to understand what happened there. My typical git workflow > does not seem to be working well for this project. I believe you can click on "edit" and then select which branch to use to create the diff. > Regarding the changes requested to > `JavaThread::pd_get_top_frame_for_profiling`, is there an issue/pr for > tracking the changes you are requesting? https://github.com/openjdk/jdk/commit/f37bfeadcf036a75defc64ad7f4a9f5596cd7407 ------------- PR: https://git.openjdk.java.net/jdk/pull/6885
