On 27/01/2022 10:19 am, Tyler Steele wrote:
On Tue, 25 Jan 2022 06:10:19 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
Tyler Steele has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains two commits:
- Merge branch 'master' into JDK-8203290
- Implements JFR on AIX
- Implements interfaces from os_perf.hpp in os_perf_aix.cpp
- Updates libperfstat_aix to contain functionality needed by os_perf_aix
- Implements missing functionality in loadlib_aix (Fixes failure noted
by TestNativeLibraies.java)
- Removes platform checks for --enable-feature-jfr (Now enable-able on
all platforms)
- Enables TestNetworkUtilizationEvent.java which now passes on AIX
- Updates AIX JavaThread::pd_get_top_frame_for_profiling with changes from
Linux
src/hotspot/os/aix/libperfstat_aix.cpp line 2:
1: /*
2: * Copyright (c) 2022, 2022, Oracle and/or its affiliates. All rights
reserved.
Is there a reason for this copyright addition?
Yes there is, but it might not be a correct one as David's and your comments
seem to indicate 😏
The thought was that as a member of a company that has signed the OCA, work I
do falls under Oracle's copyright. So any files I modify ought to have their
copyright years updated. When there wasn't an Oracle copyright line, I added
one (this may have been the problematic choice). Any guidance on how to do this
properly is appreciated.
IANAL but a basic rule I epouse is to never touch anyone else's
copyright line. If a file with a non-Oracle copyright is updated
significantly by anyone they can add their own copyright line
appropriate to their situation. But AFAIK only Oracle employees should
add Oracle copyright lines.
Cheers,
David
-----
