On Sat, 29 Jan 2022 06:36:32 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>> Tyler Steele has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Changes macoss -> macosx in problem list >> - Refactors loadlib_aix: Removes redundant c++ class > > src/hotspot/os/aix/os_perf_aix.cpp line 495: > >> 493: char* name = NEW_C_HEAP_ARRAY(char, IDENTIFIER_LENGTH, >> mtInternal); >> 494: char* exe_name = NEW_C_HEAP_ARRAY(char, PRFNSZ, mtInternal); >> 495: char* cmd_line = NEW_C_HEAP_ARRAY(char, PRARGSZ, mtInternal); > > So the contract with SystemProcess is that its ctor arguments need to be > C-heap allocated, and releases them itself? ... okay. May be worthwhile to > clean up at some point, or at least comment. Yeah, this was a bit of a gotcha during development (especially since NetworkInterface is different); I agree it's worth documenting. ------------- PR: https://git.openjdk.java.net/jdk/pull/6885
