On Mon, 31 Jan 2022 22:35:35 GMT, David Holmes <dhol...@openjdk.org> wrote:
>> Alan Hayward has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix popframe failures > > src/hotspot/cpu/aarch64/vm_version_aarch64.cpp line 429: > >> 427: #else >> 428: warning("UseROPProtection specified, but not supported in the VM."); >> 429: #endif > > If we issue these warnings should `_rop_protection` still be set true? As per this conversation: https://github.com/openjdk/jdk/pull/6334#discussion_r791722292 The idea was, the user is explicitly asking for asking for pac-ret so we should honour that. Whereas standard would only enable what is supported for that system. ------------- PR: https://git.openjdk.java.net/jdk/pull/6334