On Thu, 10 Mar 2022 10:31:17 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> make/autoconf/jdk-version.m4 line 507: >> >>> 505: # Set vendor version string if --without is not passed >>> 506: # Check not required if an empty value is passed, since >>> VENDOR_VERSION_STRING >>> 507: # would then be set to "" >> >> I'm not sure that works. In general, values like these are *supposed* to >> have a value. The default fallback is "N/A", which is not the empty string. >> I see no point in allowing overriding this to be empty. It just introduces >> cases where the build might fail later, for something that will hardly ever >> be tested. > > I treated this differently since it didn't seem to have any default value at > all, as opposed to the other vendor options. I may have made a mistake while > looking for where the vendor version string is defined in this case It's in make/conf/branding.conf. ------------- PR: https://git.openjdk.java.net/jdk/pull/7713
