On Tue, 1 Mar 2022 20:18:11 GMT, Man Cao <m...@openjdk.org> wrote: > Hi all, > > Could anyone help review the addition of LICENSE file to hsdis directory? > > -Man
The consistency is to have the license information in its own file, like other 3rd party code in OpenJDK. There two ways: - Add a LICENSE file or a similar text file. There is src/java.desktop/share/native/libsplashscreen/libpng/LICENSE and make/data/cldr/unicode-license.txt. - Add markdown files in share/legal subdirectory. Many examples exist such as src/java.xml/share/legal/. This approach seems mainly used for source code in Java. Do you think it is better to follow the "share/legal" approach such as adding a file src/utils/hsdis/share/legal/hsdis.md ? ------------- PR: https://git.openjdk.java.net/jdk/pull/7649
